Re: [PATCH] xfs: split an assert in xfs_trans_log_buf
Carlos Maiolino <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 20, 2026 at 11:36:12AM +0200, Christoph Hellwig wrote: > Split the "irst <= last && last < BBTOB(bp->b_length)" assert into two to > make it clear which condition fired. > > Signed-off-by: Christoph Hellwig <[email protected]> > --- > fs/xfs/xfs_trans_buf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c > index 1e025848811a..a5d25b703dfc 100644 > --- a/fs/xfs/xfs_trans_buf.c > +++ b/fs/xfs/xfs_trans_buf.c > @@ -521,7 +521,8 @@ xfs_trans_log_buf( > { > struct xfs_buf_log_item *bip = bp->b_log_item; > > - ASSERT(first <= last && last < BBTOB(bp->b_length)); > + ASSERT(first <= last); > + ASSERT(last < BBTOB(bp->b_length)); > ASSERT(!(bip->bli_flags & XFS_BLI_ORDERED)); > > xfs_trans_dirty_buf(tp, bp); Ops, I think this fell through the cracks. Looks good though... Reviewed-by: Carlos Maiolino <[email protected]> > -- > 2.53.0 >