Re: [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
Carlos Maiolino <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 20, 2026 at 04:09:21PM +0200, Christoph Hellwig wrote:
> Check for an internal RT device to remove a bit of extra work.
>
> Fixes: bdc03eb5f98f ("xfs: allow internal RT devices for zoned mode")
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 63c4bcbe6c2b..d96f3781d791 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -445,7 +445,7 @@ xfs_shutdown_devices(
> blkdev_issue_flush(mp->m_logdev_targp->bt_bdev);
> invalidate_bdev(mp->m_logdev_targp->bt_bdev);
> }
> - if (mp->m_rtdev_targp) {
> + if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp) {
> blkdev_issue_flush(mp->m_rtdev_targp->bt_bdev);
> invalidate_bdev(mp->m_rtdev_targp->bt_bdev);
> }
Looks good too.
Reviewed-by: Carlos Maiolino <[email protected]>
> --
> 2.53.0
>
>