Re: [PATCH net-next v2 2/2] net: dsa: realtek: rtl83xx: add support for enabling supplies

On Tue, Aug 11, 2026 at 1:39 PM Oleksij Rempel <[email protected]> wrote:

> From: Ahmad Fatoum <[email protected]>
>
> The power supplies powering the IC may not necessarily be enabled by the
> time the driver probes.  The binding describes the power rails, so enable
> them at probe with devm_regulator_bulk_get_enable(), before the reset line
> is requested and driven, so the chip is powered before its pins are driven.
>
> Boards that do not describe these supplies fall back to dummy regulators
> (with a "supply not found" warning) and keep working as before.
>
> A board that describes supplies but no reset line still needs to wait for
> the chip to boot before the first register access, so apply the existing
> start delay in that case too.
>
> Signed-off-by: Alvin Šipraga <[email protected]>
> Signed-off-by: Ahmad Fatoum <[email protected]>
> Co-developed-by: Oleksij Rempel <[email protected]>
> Signed-off-by: Oleksij Rempel <[email protected]>

Kudos for all the detailed explanations!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij