[PATCH 2/2] gpio: qcom_pmic_gpio: don't reset pull on direction change
Petr Hodina via B4 Relay <[email protected]>
| Newsgroups | org.kernel.vger.phone-devel,org.kernel.feeds.b4-sent,org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
From: Petr Hodina <[email protected]> Fix for pull-up/pull-down/disable as that's independent of the direction. Signed-off-by: Petr Hodina <[email protected]> --- drivers/gpio/qcom_pmic_gpio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpio/qcom_pmic_gpio.c b/drivers/gpio/qcom_pmic_gpio.c index 71cc76fef2f..e67e138ede2 100644 --- a/drivers/gpio/qcom_pmic_gpio.c +++ b/drivers/gpio/qcom_pmic_gpio.c @@ -129,12 +129,6 @@ static int qcom_gpio_set_direction(struct udevice *dev, unsigned int offset, _qcom_gpio_set_direction(dev, offset, input, value); - /* Set the right pull (no pull) */ - ret = pmic_reg_write(plat->pmic, gpio_base + REG_DIG_PULL_CTL, - REG_DIG_PULL_NO_PU); - if (ret < 0) - return ret; - /* Configure output pin drivers if needed */ if (!input) { /* Select the VIN - VIN0, pin is input so it doesn't matter */ -- 2.53.0