Re: update check_cmn_err

Dan Carpenter <[email protected]> Mon, 18 Nov 2024 11:02:21 +0300
Newsgroups org.kernel.vger.smatch
Message-ID <[email protected]>
On Mon, Nov 18, 2024 at 09:51:37AM +0200, Toomas Soome wrote:
> Hi!
> 
> I would like to update work done by John Levon, there is other function,
> similar to cmn_err().
> 

The cmn_err() function is a function in Illumos where if you pass CE_PANIC to
it then it doesn't return.  Presumably if Smatch doesn't parse this correctly,
then you end up with tons of uninitialized variable false positives.  Probably
other false positives as well.

Smatch is heavily tuned for the Linux kernel because that's where my focus has
been for the past fifteen years.  Most of the easy parsing issues for the Linux
kernel are already addressed.  Outside of the Linux kernel then Smatch is very
untuned and quite bad.

regards,
dan carpenter