Re: update check_cmn_err

> On 18. Nov 2024, at 10:02, Dan Carpenter <[email protected]> =
wrote:
>=20
> On Mon, Nov 18, 2024 at 09:51:37AM +0200, Toomas Soome wrote:
>> Hi!
>>=20
>> I would like to update work done by John Levon, there is other =
function,
>> similar to cmn_err().
>>=20
>=20
> The cmn_err() function is a function in Illumos where if you pass =
CE_PANIC to
> it then it doesn't return.  Presumably if Smatch doesn't parse this =
correctly,
> then you end up with tons of uninitialized variable false positives.  =
Probably
> other false positives as well.
>=20
> Smatch is heavily tuned for the Linux kernel because that's where my =
focus has
> been for the past fifteen years.  Most of the easy parsing issues for =
the Linux
> kernel are already addressed.  Outside of the Linux kernel then Smatch =
is very
> untuned and quite bad.
>=20
> regards,
> dan carpenter

Yep, this is for illumos, and since John did upstream the cmn_err() =
check, I would like to complement it with ddi_err() as well;) We =
currently do have a bit older version of smatch in use and I=E2=80=99m =
working to update it. Despite the issues noted, it is still rather =
helpful of detecting problems;)

thanks,
toomas=