Re: [PATCH 05/10] irqtop: improve several more option descriptions, and align them all
Benno Schulenberg <[email protected]>
| Newsgroups | org.kernel.vger.util-linux |
|---|---|
| Message-ID | <[email protected]> |
Op 31-03-2025 om 17:02 schreef Joe Jin:
> On 3/31/25 02:44, Benno Schulenberg wrote:
>> fputs(_("\nThe following interactive key commands are valid:\n"), stdout);
>> fputs(_(" i sort by IRQ\n"), stdout);
>> fputs(_(" t sort by TOTAL\n"), stdout);
>> fputs(_(" d sort by DELTA\n"), stdout);
>> fputs(_(" n sort by NAME\n"), stdout);
>> - fputs(_(" q Q quit program\n"), stdout);
>> + fputs(_(" q quit program\n"), stdout);
>
> Why remove the "Q"?
It looks ugly. And why would the user want to hold Shift before pressing q,
when just pressing q will do? Holding Shift has no extra effect.
If the user has CapsLock activated, they will simply press the q key, and
expect it to work -- and it will work, like they know from other tools.
No need to explicitly mention this, because it makes it seem as if it is
something special.
Benno
OpenPGP_signature.asc
(application/pgp-signature, 840 B)
-----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEEFo5vQpe/16ea/USWUUu+Lrjhlh8FAmfquQoFAwAAAAAACgkQUUu+Lrjhlh9y ZBAA7Zpmx57s1vEATSXlYDvj1vm2B2HSztlvRytO7t073sLj6X/gtXmZpMz7s1E/br6BNSqA1woe O1fqmRKxE/I1tRJ2M25b3WDfS9KakGrrNa5YiNAE3F+JeYgG4RLQ0cSpUE7GdeAe+9xRq8TBLKbK 9/kxxJ2sIhWIbB7+iGxv6USsceK05uUg+WI5xxdB0gHjvgFighD+/OGgPtWNFqE30arkJkB2BoRv dk8os+oIpS0tiTGpTZtr931LZzHRtbA1Bkdm9nLEq9tdVcGV+bNW+ldNpqIxkmUTeDDMy4BI3lL4 FD6ed2HjVy7DspD3k72HT9W06mLEXKEkaPG9eQ6sUH9Q3i0GkYoj9KWtnHl310zdRPO1xJKJIPuK nC+9HmjtNbCGszka3/z6L6+QrGoiTzAD8u7aOuIVU8e9Al98z0nFDxYzqeOboQyQJg2yWQk3fLPG 0uqISP0Iv0hf8W7ux/RZIgG13/gqbFsK+FORt0AAwrnd4lMOgsPvniCYo4IQmPUlE3fNWe5Z0M56 VUy0t+bM8W3qcU4bC3+vSBirrOosbFA8n9RhMUmVRcN9cIJ6cVBsq1KjwV+PwCiM7HWt/xEBR8UH Qd5P+Ik57TCF0crzR+7kSn4jdhDS3IrVvhGpMo9xGwSd/OfLfDRXbzRPa3pJQlqDMkCMJXMDt4JO cgI= =zRx4 -----END PGP SIGNATURE-----