Re: [PATCH 05/10] irqtop: improve several more option descriptions, and align them all

On 3/31/25 08:47, Benno Schulenberg wrote:
>
> Op 31-03-2025 om 17:02 schreef Joe Jin:
>> On 3/31/25 02:44, Benno Schulenberg wrote:
>>>       fputs(_("\nThe following interactive key commands are valid:\n"), stdout);
>>>       fputs(_("  i      sort by IRQ\n"), stdout);
>>>       fputs(_("  t      sort by TOTAL\n"), stdout);
>>>       fputs(_("  d      sort by DELTA\n"), stdout);
>>>       fputs(_("  n      sort by NAME\n"), stdout);
>>> -    fputs(_("  q Q    quit program\n"), stdout);
>>> +    fputs(_("  q      quit program\n"), stdout);
>>
>> Why remove the "Q"?
>
> It looks ugly.  And why would the user want to hold Shift before pressing q,
> when just pressing q will do?  Holding Shift has no extra effect.

Then should it be removed from parse_input() as well?

Thanks,
Joe

>
> If the user has CapsLock activated, they will simply press the q key, and
> expect it to work -- and it will work, like they know from other tools.
> No need to explicitly mention this, because it makes it seem as if it is
> something special.
>
>
> Benno
>