Re: [PATCH 09/10] coresched: reduce excessive whitespace and verbosity in usage text
Karel Zak <[email protected]>
| Newsgroups | org.kernel.vger.util-linux |
|---|---|
| Message-ID | <cztqfu3prb4v2urpxrujq5wqqdclnxwsny4h5ejbml7d7kll2n@yj3dgreqhtrl> |
On Mon, Mar 31, 2025 at 11:44:42AM +0200, Benno Schulenberg wrote: > Also, use semicolons instead of periods in option descriptions. > > And consistently use an uppercased "PID" in feedback messages. > > CC: Phil Auld <[email protected]> > CC: Thijs Raymakers <[email protected]> > Signed-off-by: Benno Schulenberg <[email protected]> > --- > schedutils/coresched.c | 33 +++++++++++++-------------------- > 1 file changed, 13 insertions(+), 20 deletions(-) > > diff --git a/schedutils/coresched.c b/schedutils/coresched.c > index 9d8be3e12..7634d988c 100644 > --- a/schedutils/coresched.c > +++ b/schedutils/coresched.c > @@ -80,31 +80,24 @@ static void __attribute__((__noreturn__)) usage(void) > program_invocation_short_name); > > fputs(USAGE_SEPARATOR, stdout); > - fputsln(_("Manage core scheduling cookies for tasks."), stdout); > + fputsln(_("Manage core-scheduling cookies for tasks."), stdout); > > fputs(USAGE_FUNCTIONS, stdout); > - fputsln(_(" get retrieve the core scheduling cookie of a PID"), > - stdout); > - fputsln(_(" new assign a new core scheduling cookie to an existing\n" > - " PID or execute a program with a new cookie"), > - stdout); > - fputsln(_(" copy copy the core scheduling cookie from an existing PID\n" > - " to another PID, or execute a program with that\n" > - " copied cookie"), > - stdout); > + fputsln(_(" get retrieve the core-scheduling cookie of a PID"), stdout); There is a comment from Thijs that kernel docs does not use hyphen, it means "core scheduling" rather than "core-scheduling". Maybe it would be better to follow kernel. https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/core-scheduling.html https://github.com/util-linux/util-linux/pull/3500 Karel -- Karel Zak <[email protected]> http://karelzak.blogspot.com