Re: [PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

Jonathan Corbet <[email protected]>
Newsgroups org.kernel.vger.workflows,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Uwe Kleine-König <[email protected]> writes:

> The first parameter should match the variable that the allocated memory
> is assigned to. Fix the example accordingly, the one for kmalloc_obj got
> it right already.
>
> Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-family")
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
>  Documentation/process/coding-style.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index a3bf75dc7c88..a8336582f60b 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -959,13 +959,13 @@ The preferred form for allocating an array is the following:
>  
>  .. code-block:: c
>  
> -	p = kmalloc_objs(*ptr, n, ...);
> +	p = kmalloc_objs(*p, n, ...);
>  
>  The preferred form for allocating a zeroed array is the following:
>  
>  .. code-block:: c
>  
> -	p = kzalloc_objs(*ptr, n, ...);
> +	p = kzalloc_objs(*p, n, ...);
>  
>  Both forms check for overflow on the allocation size n * sizeof(...),
>  and return NULL if that occurred.

Applied, thanks.

jon
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.