Re: [PATCH v2 09/10] target/arm: Annotate arch revisions in aarch64_max_tcg_initfn

On Wed, 12 Aug 2026 at 21:46, Richard Henderson
<[email protected]> wrote:
>
> Annotate the minimum revion from which each feature is OPTIONAL.
> Modulo some sorting of properties at the end, comment changes only.
>
> Signed-off-by: Richard Henderson <[email protected]>
> ---
>  target/arm/tcg/cpu64.c | 303 +++++++++++++++++++++--------------------
>  1 file changed, 159 insertions(+), 144 deletions(-)


>      t = GET_IDREG(isar, ID_AA64ISAR1);
> -    t = FIELD_DP64(t, ID_AA64ISAR1, DPB, 2);      /* FEAT_DPB2 */
> -    t = FIELD_DP64(t, ID_AA64ISAR1, APA, PauthFeat_FPACCOMBINED);
> +    t = FIELD_DP64(t, ID_AA64ISAR1, DPB, 2);      /* v8.1: FEAT_DPB2 */
> +    t = FIELD_DP64(t, ID_AA64ISAR1, APA, PauthFeat_FPACCOMBINED); /* v8.2 */
>      t = FIELD_DP64(t, ID_AA64ISAR1, API, 1);

Out of scope for this series, but this value for API is wrong:
if we implement FEAT_FPACCOMBINE (as we report with APA = 5)
then we should also report API = 5. aarch64_cpu_pauth_finalize()
fixes this up because it always rewrites these fields, but
probably better to start with a consistent set of values here.

-- PMM