Re: [PATCH v2 7/8] target/arm: Implement CPACR.D32DIS

On 8/17/26 05:38, Peter Maydell wrote:
> On some v7A CPUs, CPACR.D32DIS is a bit allowing the guest to make
> VFP instructions that touch registers D16..D31 UNDEF.  Whether the
> CPU implements this or not is IMPDEF, and the only two CPUs we
> implement which have this are the Cortex-A7 and Cortex-A9.  In v8A
> the bit is no longer defined at all.
> 
> Since the only kind of trapping that needs to be done is a simple
> UNDEF, this is straightforward enough to implement.
> 
> Resolves:https://gitlab.com/qemu-project/qemu/-/work_items/1499
> Signed-off-by: Peter Maydell<[email protected]>
> ---
>   target/arm/cpu.h               |  4 ++++
>   target/arm/helper.c            | 19 ++++++++++++++++---
>   target/arm/tcg/cpu32.c         |  2 ++
>   target/arm/tcg/hflags.c        | 20 ++++++++++++++++++++
>   target/arm/tcg/translate-vfp.c |  7 ++-----
>   target/arm/tcg/translate.c     |  6 ++++++
>   target/arm/tcg/translate.h     |  1 +
>   7 files changed, 51 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <[email protected]>

r~