Re: [PATCH v2 6/8] target/arm: Pull VFP dregs checks out into a function

On 8/17/26 05:38, Peter Maydell wrote:
> Currently we directly call dc_isar_feature(aa32_simd_r32, s) for VFP
> insns that use D16-D31 to see if they should UNDEF.  For some v7A
> CPUs (Cortex-A7, Cortex-A9) there is also a CPACR.D32DIS trap bit
> that will make VFP (and only VFP, not Neon) insns using D16-D31
> UNDEF.
> 
> Abstract out the register check for VFP insns into a new function
> which will provide us a place where we can make this check.
> 
> Since D32DIS takes precedence over traps to EL2 and EL3 and simply
> makes the insns UNDEF, we are OK to check it at the same point when
> we do the CPU feature check, rather than having to wait until
> vfp_access_check().
> 
> Signed-off-by: Peter Maydell<[email protected]>
> ---
>   target/arm/tcg/translate-vfp.c | 70 ++++++++++++++++++++--------------
>   1 file changed, 42 insertions(+), 28 deletions(-)

Reviewed-by: Richard Henderson <[email protected]>

r~