Re: [PATCH 16/56] disas/riscv: Drop useless const in structures
Alistair <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, 2026-08-09 at 15:35 -0700, Richard Henderson wrote: > Individual fields should not be const, only full structures. > > Signed-off-by: Richard Henderson <[email protected]> Reviewed-by: Alistair Francis <[email protected]> Alistair > --- > disas/riscv.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/disas/riscv.h b/disas/riscv.h > index eabe193b4f..3325b7b4ef 100644 > --- a/disas/riscv.h > +++ b/disas/riscv.h > @@ -174,19 +174,19 @@ typedef enum { > /* structures */ > > typedef struct { > - const int op; > + int op; > const rvc_constraint *constraints; > } rv_comp_data; > > typedef struct { > - const char * const name; > - const rv_codec codec; > - const char * const format; > + const char *name; > + rv_codec codec; > + const char *format; > const rv_comp_data *pseudo; > - const short decomp_rv32; > - const short decomp_rv64; > - const short decomp_rv128; > - const short decomp_data; > + short decomp_rv32; > + short decomp_rv64; > + short decomp_rv128; > + short decomp_data; > } rv_opcode_data; > > typedef struct {