Re: [PATCH 17/56] disas/riscv: Drop codec from rv_decode

On Sun, 2026-08-09 at 15:35 -0700, Richard Henderson wrote:
> This is mostly write-only, only used in one place;
> other updates are ignored.
> 
> Signed-off-by: Richard Henderson <[email protected]>

Reviewed-by: Alistair Francis <[email protected]>

Alistair

> ---
>  disas/riscv.h | 1 -
>  disas/riscv.c | 7 +++----
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/disas/riscv.h b/disas/riscv.h
> index 3325b7b4ef..31bb0db86c 100644
> --- a/disas/riscv.h
> +++ b/disas/riscv.h
> @@ -197,7 +197,6 @@ typedef struct {
>      int32_t   imm;
>      int32_t   imm1;
>      uint16_t  op;
> -    uint8_t   codec;
>      uint8_t   rd;
>      uint8_t   rs1;
>      uint8_t   rs2;
> diff --git a/disas/riscv.c b/disas/riscv.c
> index ec40abb618..9813d75feb 100644
> --- a/disas/riscv.c
> +++ b/disas/riscv.c
> @@ -4603,8 +4603,9 @@ static void decode_inst_operands(rv_decode
> *dec, rv_isa isa,
>  {
>      rv_inst inst = dec->inst;
>  
> -    dec->codec = op->codec;
> -    switch (dec->codec) {
> +    switch (op->codec) {
> +    case rv_codec_illegal:
> +        break;
>      case rv_codec_none:
>          dec->rd = dec->rs1 = dec->rs2 = rv_ireg_zero;
>          dec->imm = 0;
> @@ -5369,7 +5370,6 @@ static const rv_opcode_data
> *decode_inst_lift_pseudo(rv_decode *dec,
>              if (check_constraints(dec, comp_data->constraints)) {
>                  dec->op = comp_data->op;
>                  op = &dec->opcode_data[dec->op];
> -                dec->codec = op->codec;
>                  break;
>              }
>              comp_data++;
> @@ -5407,7 +5407,6 @@ static const rv_opcode_data
> *decode_inst_decompress(rv_decode *dec, rv_isa isa,
>              dec->op = decomp_op;
>          }
>          op = &dec->opcode_data[decomp_op];
> -        dec->codec = op->codec;
>      }
>      return op;
>  }