Re: [PATCH v4 18/20] target/xtensa: Constify CPUXtensaState in xtensa_replicate_windowstart()

On Mon, Aug 24, 2026 at 4:20 AM Philippe Mathieu-Daudé
<[email protected]> wrote:
>
> Add the const qualifier to CPUXtensaState when the
> argument is accessed without modification.
>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> ---
>  target/xtensa/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Filippov <[email protected]>

> diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu.h
> index 442e98bd1ba..49d6ad9083d 100644
> --- a/target/xtensa/cpu.h
> +++ b/target/xtensa/cpu.h
> @@ -708,7 +708,7 @@ void xtensa_set_abi_call0(void);
>  bool xtensa_abi_call0(void);
>  #endif
>
> -static inline uint32_t xtensa_replicate_windowstart(CPUXtensaState *env)
> +static inline uint32_t xtensa_replicate_windowstart(const CPUXtensaState *env)
>  {
>      return env->sregs[WINDOW_START] |
>          (env->sregs[WINDOW_START] << env->config->nareg / 4);
> --
> 2.53.0
>

-- 
Thanks.
-- Max