Re: [PATCH 5/5] Revert "sysbus: add irq_routing_notifier"

Am 4. Mai 2026 09:51:05 UTC schrieb "Cédric Le Goater" <[email protected]>:
>On 4/27/26 12:30, Bernhard Beschow wrote:
>> 
>> 
>> Am 9. März 2026 09:19:10 UTC schrieb "Cédric Le Goater" <[email protected]>:
>>> On 3/8/26 21:35, Bernhard Beschow wrote:
>>>> The callback has been introduced in commit 715ca691daca ("sysbus: add
>>>> irq_routing_notifier") for use in VFIO platform. Meanwhile, VFIO
>>>> platform has been removed via commit 762c85543948 ("vfio: Remove 'vfio-
>>>> platform'") which was its only user. Remove this unused code.
>>>> 
>>>> This reverts commit 715ca691daca081108b33306faa6fa102f0df8d8.
>>>> 
>>>> cc: Cédric Le Goater <[email protected]>
>>>> Signed-off-by: Bernhard Beschow <[email protected]>
>>>> ---
>>>>    include/hw/core/sysbus.h | 1 -
>>>>    hw/core/sysbus.c         | 6 ------
>>>>    2 files changed, 7 deletions(-)
>>>> 
>>>> diff --git a/include/hw/core/sysbus.h b/include/hw/core/sysbus.h
>>>> index c0d18d9e00..f3c4259d29 100644
>>>> --- a/include/hw/core/sysbus.h
>>>> +++ b/include/hw/core/sysbus.h
>>>> @@ -50,7 +50,6 @@ struct SysBusDeviceClass {
>>>>         * omitted then. (This is not considered a fatal error.)
>>>>         */
>>>>        char *(*explicit_ofw_unit_address)(const SysBusDevice *dev);
>>>> -    void (*connect_irq_notifier)(SysBusDevice *dev, qemu_irq irq);
>>>>    };
>>>>      struct SysBusDevice {
>>>> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
>>>> index 3adf2f2faf..3e1160ee92 100644
>>>> --- a/hw/core/sysbus.c
>>>> +++ b/hw/core/sysbus.c
>>>> @@ -104,13 +104,7 @@ qemu_irq sysbus_get_connected_irq(const SysBusDevice *dev, int n)
>>>>      void sysbus_connect_irq(SysBusDevice *dev, int n, qemu_irq irq)
>>>>    {
>>>> -    SysBusDeviceClass *sbd = SYS_BUS_DEVICE_GET_CLASS(dev);
>>>> -
>>>>        qdev_connect_gpio_out_named(DEVICE(dev), SYSBUS_DEVICE_GPIO_IRQ, n, irq);
>>>> -
>>>> -    if (sbd->connect_irq_notifier) {
>>>> -        sbd->connect_irq_notifier(dev, irq);
>>>> -    }
>>>>    }
>>>>      /* Check whether an MMIO region exists */
>>> 
>>> Reviewed-by: Cédric Le Goater <[email protected]>
>>> 
>>> Thanks,
>>> 
>>> C.
>> 
>> Who will pick up this patch?
>I would say this is a qdev related matter, so Paolo ?

Meanwhile, Peter took already care of it by applying the patch to target-arm.next and issuing a pull request -- thanks, Peter!

Best regards,
Bernhard

>
>Thanks,
>
>C.
>