Re: [PATCH 1/3] hw/misc/imx_ccm: Replace DPRINTF with trace events

Peter Maydell <[email protected]> Thu, 25 Jun 2026 15:56:39 +0100

Newsgroups	org.nongnu.qemu-trivial,org.nongnu.qemu-arm,org.nongnu.qemu-devel
Message-ID	<CAFEAcA9fS9v-=BTSVM+BJg8V3hbFf7q9xaP3MMVFC04cFJ7HVw@mail.gmail.com>

On Tue, 23 Jun 2026 at 18:04, jack wang <[email protected]> wrote:
>
> ---
>  hw/misc/imx_ccm.c    | 18 +++---------------
>  hw/misc/trace-events |  4 ++++
>  2 files changed, 7 insertions(+), 15 deletions(-)

>  uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
> @@ -37,7 +26,7 @@ uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
>          freq = klass->get_clock_frequency(dev, clock);
>      }
>
> -    DPRINTF("(clock = %d) = %u\n", clock, freq);
> +    trace_imx_ccm_get_clock_frequency(clock,freq);

Our coding style wants a space after this comma.
(Running your patches through scripts/checkpatch.pl can
catch this kind of style nit, though it sometimes has
false positives.)

Otherwise
Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM