Re: [PATCH 2/3] hw/misc/imx25_ccm: Replace DPRINTF with trace events

On Tue, 23 Jun 2026 at 18:04, jack wang <[email protected]> wrote:
>
> ---
>  hw/misc/imx25_ccm.c  | 34 ++++++++++------------------------
>  hw/misc/trace-events |  9 +++++++++
>  2 files changed, 19 insertions(+), 24 deletions(-)

This patch and patch 3 are missing your Signed-off-by:
line; we can't take them without it.


> -    DPRINTF("reg[%s] <= 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2),
> -            (uint32_t)value);
> +    trace_imx25_ccm_write(imx25_ccm_reg_name(offset >> 2), (uint32_t)value);

You can drop the uint32_t cast here. We needed it with DPRINTF
because that's a variadic function. But the trace version
is a normal function and because the argument's type there
is uint32_t C will do the conversion for us automatically.

Otherwise
Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM