Re: [PATCH v3 3/3] hw/usb/hcd-xhci: Use qemu_log_mask() instead of fprintf() statement

On 13/07/2026 12.17, Peter Maydell wrote:
> On Mon, 13 Jul 2026 at 11:05, Thomas Huth <[email protected]> wrote:
>>
>> From: Thomas Huth <[email protected]>
>>
>> We've got a proper way for logging unimplemented hardware features,
>> so use qemu_log_mask() instead of the fprintf() here now.
>>
>> Suggested-by: Peter Maydell <[email protected]>
>> Signed-off-by: Thomas Huth <[email protected]>
>> ---
>>   hw/usb/hcd-xhci.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index ee913d5c4d5..527910d92d2 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -1017,7 +1017,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext *epctx,
>>           }
>>           sctx = epctx->pstreams + streamid;
>>       } else {
>> -        fprintf(stderr, "xhci: FIXME: secondary streams not implemented yet");
>> +        qemu_log_mask(LOG_UNIMP,
>> +                      "xhci: secondary streams not implemented yet");
>>           *cc_error = CC_INVALID_STREAM_TYPE_ERROR;
>>           return NULL;
>>       }
> 
> qemu_log_mask() strings need a trailing "\n" (as of course does
> printing messages to stderr :-)).

D'oh, I forgot it again! Thanks for spotting it! I'll send an updated version...

> Otherwise
> Reviewed-by: Peter Maydell <[email protected]>
Thanks!

  Thomas