Re: [PATCH v3 2/3] hw/usb/hcd-xhci: Remove the FIXME macro

On 13/07/2026 12.16, Peter Maydell wrote:
> On Mon, 13 Jul 2026 at 11:05, Thomas Huth <[email protected]> wrote:
>>
>> From: Thomas Huth <[email protected]>
>>
>> The FIXME macro is only used in one case, which should hopefully
>> never trigger: The containing function handles all the USB_RET_*
>> values except for USB_RET_ADD_TO_QUEUE and USB_RET_REMOVE_FROM_QUEUE,
>> which are both internal return values for when an async packet needs
>> to be queued or dequeued, and which shouldn't still be the status by
>> the time we get to this function. Thus let's simplify this spot
>> and use a g_assert_not_reached() instead.
>>
>> Suggested-by: Peter Maydell <[email protected]>
>> Signed-off-by: Thomas Huth <[email protected]>
>> ---
>>   hw/usb/hcd-xhci.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Reviewed-by: Peter Maydell <[email protected]>
> 
> Not sure if some compilers/analyzers would complain about the
> DPRINTF followed by g_assert_not_reached().
I hope they don't complain since the macro is disabled by default...? Or 
shall we play save and remove the DPRINTF here, too?

  Thomas