Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets (+ b4 check signed-off-problems)

--nextPart3933016.MHq7AAxBmi
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Sven Eckelmann <[email protected]>
Date: Sat, 01 Aug 2026 11:54:03 +0200
Message-ID: <3801416.R56niFO833@sven-desktop>
In-Reply-To: <[email protected]>
References: <[email protected]>
MIME-Version: 1.0

On Friday, 31 July 2026 15:52:22 CEST David Lee wrote:
> Signed-off-by: Kyle Zeng <[email protected]>

Another thing just realized (and for whatever reason it was not shown by b4): 
Who is Kyle Zeng <[email protected]> here (what does kylebot have to do 
with the patch)? David Lee <[email protected]> is here marked as the 
author but didn't even Signed-off-by the patch. See 
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
(see the end of mail of pending things for this patch)



@Konstanin (Joe/Andy): Is it to be expected that 
`b4 review track [email protected]` -> 
`b4 review tui` -> "review" -> "checks" patch doesn't show the Signed-off-by 
error in the checkpatch check view? When doing it manually, it works as 
expected:

$ b4 am [email protected]
[..]
$ ./scripts/checkpatch.pl -q --terse --no-summary ./20260731_david_lee_batman_adv_reject_unrepresentable_multicast_tvlv_offsets.mbx
./20260731_david_lee_batman_adv_reject_unrepresentable_multicast_tvlv_offsets.mbx:52: ERROR: Missing Signed-off-by: line by nominal patch author 'David Lee <[email protected]>'

$ b4 --version
0.15.2

The difference comes from the "--mailback" option which b4 adds also to 
checkpatch. I have therefore also Cc'ed Joe Perches and Andy Whitcroft because 
of this suppressed error. The following change would produce the output but I 
have no glue and just fiddled around with the script without understanding the 
bigger concept (of checkpatch and why b4 uses --mailback):

diff --git i/scripts/checkpatch.pl w/scripts/checkpatch.pl
index 7a846a3ea1273..ccb2ec78193e0 100755
--- i/scripts/checkpatch.pl
+++ w/scripts/checkpatch.pl
@@ -7846,12 +7846,6 @@ sub process {
 		exit(0);
 	}
 
-	# In mailback mode only produce a report in the negative, for
-	# things that appear to be patches.
-	if ($mailback && ($clean == 1 || !$is_patch)) {
-		exit(0);
-	}
-
 	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
@@ -7902,6 +7896,12 @@ sub process {
 		}
 	}
 
+	# In mailback mode only produce a report in the negative, for
+	# things that appear to be patches.
+	if ($mailback && ($clean == 1 || !$is_patch)) {
+		exit(0);
+	}
+
 	print report_dump();
 	if ($summary && !($clean == 1 && $quiet == 1)) {
 		print "$filename " if ($summary_file);

(this is just to show the cause - not meant as anything which should be applied)

Regards,
	Sven
--nextPart3933016.MHq7AAxBmi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCam3COwAKCRBND3cr0xT1
y0m5AQChINdIzm/w0zU7bfoEbd9BJ5+g/WSUN+VWYEDRgtHNCwD+IW00Wn77OkYu
fXiFXJUuvzn420Zc+jPEKhYkJB01gw8=
=/H5g
-----END PGP SIGNATURE-----

--nextPart3933016.MHq7AAxBmi--