Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets

--nextPart48293242.fMDQidcC6G
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Sven Eckelmann <[email protected]>
Date: Sat, 01 Aug 2026 11:55:39 +0200
Message-ID: <1966817.atdPhlSkOF@sven-desktop>
In-Reply-To: <178551276852.62695.13954065440231922020.b4-review@b4>
MIME-Version: 1.0

On Friday, 31 July 2026 17:46:08 CEST Sven Eckelmann wrote:
> On Fri, 31 Jul 2026 13:52:22 +0000, David Lee <[email protected]> wrote:
> > batman-adv: reject unrepresentable multicast TVLV offsets
> 
> Acked-by: Sven Eckelmann <[email protected]>

I am hereby withdrawing this.

NACKed-by: Sven Eckelmann <[email protected]>

This needs a different implementation and a clean patch submission. Summary:

1. weird text + newlines in the tags section which shouldn't be there

2. author didn't sign off the patch

3. weird unrelated Signed-off-by without any understandable connection to 
   patch

4. the checks should be in the API and not added in random places in callers 
   of the API (which makes it hard to understand why the check is there). The 
   users of the API should only handle the return values of the API functions. 
   See commit d45cf1e7d718 ("ipv6: reject malicious packets in 
   ipv6_gso_segment()")

Regards,
	Sven
--nextPart48293242.fMDQidcC6G
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCam3CmwAKCRBND3cr0xT1
y2mgAQDi/oHdlfdCkY06CmxenfGT17EvCOmDReQEwv8Eoa1fowEAzrJdzx7R4ZZB
ZhJwKVbiHfzxT4cfFHnj4VqYsgjVKww=
=RJcS
-----END PGP SIGNATURE-----

--nextPart48293242.fMDQidcC6G--