Re: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter fallback message

"Loktionov, Aleksandr" <[email protected]> Thu, 23 Jul 2026 09:21:07 +0000
Newsgroups org.osuosl.intel-wired-lan,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <IA3PR11MB8986E19198FCD1756A9B90D5E5C02@IA3PR11MB8986.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Thomas Bogendoerfer
> Sent: Friday, July 17, 2026 10:45 AM
> To: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Andrew Lunn
> <[email protected]>; David S. Miller <[email protected]>; Eric
> Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
> Abeni <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter
> fallback message
> 
> Seeing an error message in a logfile triggers scripts/admins thinking
> of problems. The LLDP fallback message itself is not an error, it just
> indicates it's using a different filter mechanism. So rephrase to a
> less "scary" message.
> 
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c
> b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 8cdc4fda89e9..59341b5a0c05 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -2097,7 +2097,7 @@ void ice_vsi_cfg_sw_lldp(struct ice_vsi *vsi,
> bool tx, bool create)
>  				goto report;
> 
>  			dev_info(dev,
> -				 "Failed to add generic LLDP Rx filter on
> VSI %i error: %d, falling back to specialized AQ control\n",
> +				 "Using generic LLDP Rx filter on VSI %i is
> not possible (%d),
> +falling back to specialized AQ control\n",
>  				 vsi->vsi_num, status);
>  		}
> 
> --
> 2.51.0

Reviewed-by: Aleksandr Loktionov <[email protected]>