Re: [PATCH v3 6/7] ARM: dts: aspeed: g6: Change vuart compatible string for ast2600
Krzysztof Kozlowski <[email protected]> Wed, 24 Jun 2026 09:19:28 +0200
| Newsgroups | org.ozlabs.lists.linux-aspeed,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial |
|---|---|
| Message-ID | <20260624-copper-albatross-of-youth-6abae8@quoll> |
On Tue, Jun 23, 2026 at 02:25:44PM +0000, Grégoire Layet wrote: > Use the ast2600 compatible string. > This makes it more precise and enables specific ast2600 properties. > Still use the ast2500 compatible string as a fallback. > > Signed-off-by: Grégoire Layet <[email protected]> > --- > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index 56bb3b0444f7..7c02633f2bd6 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -707,7 +707,7 @@ emmc: sdhci@1e750100 { > }; > > vuart1: serial@1e787000 { > - compatible = "aspeed,ast2500-vuart"; > + compatible = "aspeed,ast2600-vuart", "aspeed,ast2500-vuart"; Please start testing your patches. This for sure fails tests. It does not look like you tested the DTS against bindings. Please run 'make dtbs_check W=1' (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. Best regards, Krzysztof