Re: [PATCH v2 1/2] ipmi: kcs_bmc_aspeed: g6: Add KCS Channel 4 over PCIe

On Wed, 2026-07-22 at 15:11 +0000, Gr=C3=A9goire Layet wrote:
> Created a 5th KCS channel to match against the KCS 4 over PCIe addresses.
>=20
> The ASPEED AST2600 has a PCIe to LPC controller. It includes a KCS
> interface on channel 4. This is a fully KCS-compatible interface
> that is exposed over PCIe.
>=20
> The 5th channel created is only valid on the AST2600.
> This cannot be used for AST2400 and AST2500 chips, as they don't have LPC
> over PCIE.
>=20
> Signed-off-by: Gr=C3=A9goire Layet <[email protected]>
>=20

...

> @@ -373,6 +395,9 @@ static void aspeed_kcs_enable_channel(struct kcs_bmc_=
device *kcs_bmc, bool enabl
> =C2=A0	case 4:
> =C2=A0		regmap_update_bits(priv->map, LPC_HICRB, LPC_HICRB_LPC4E, enable =
* LPC_HICRB_LPC4E);
> =C2=A0		return;
> +	case 5:
> +		regmap_update_bits(priv->map, PCIE_LPC_HICRB, LPC_HICRB_LPC4E, enable =
* LPC_HICRB_LPC4E);

This one exceeds 100 chars. checkpatch can help catch these types of
issues.

Otherwise this seems okay.

Andrew