Re: [PATCH v5 13/15] ARM: dts: aspeed: anacapa: fix dt-check-style strict violations

On 8/13/26 1:59 PM, Colin Huang via B4 Relay wrote:
> From: Colin Huang <[email protected]>
> 
> Run scripts/dtc/dt-check-style --mode strict against the Facebook
> Anacapa board device trees and fix the reported violations:
> 
>   - aspeed-bmc-facebook-anacapa.dts: drop a duplicate trailing blank
>     line at end of file.
>   - aspeed-bmc-facebook-anacapa-dvt.dts,
>     aspeed-bmc-facebook-anacapa-evt2.dts,
>     aspeed-bmc-facebook-anacapa-evt1.dts:
>     - reorder compatible/model so compatible comes first
>     - add required blank lines before child nodes and before the
>       status property
>     - sort properties into the tool's canonical bucket order (e.g.
>       bus-frequency before gpio-line-names before ngpios before
>       status in the &sgpiom0 override, m25p,fast-read/label ordering
>       in flash@0, #gpio-cells/gpio-controller/gpio-line-names
>       ordering in gpio@24 and gpio@38)
>     - align multi-line property continuations (io-channels,
>       pinctrl-0) under the opening '<' column
>     - fix child-name-order and child-address-order violations
>       (framebuffer before video in reserved-memory, gpio@24 before
>       power-monitor@N, regulator-p3v3-bmc-aux before reserved-memory)
>     - remove redundant node labels that were never &-referenced
>       anywhere in the tree (i2c8mux0ch0, i2c8mux0ch1, i2c13mux0ch7,
>       spi_gpio); these labels only existed for node-merge overrides
>       via #include and are not needed since nodes merge by name and
>       unit address
> 
> One unused-labels warning remains in evt1.dts for the p3v3_bmc_aux
> label: it is genuinely referenced via "&p3v3_bmc_aux" in
> aspeed-bmc-facebook-anacapa-evt2.dts, which #include's evt1.dts.
> dt-check-style only tracks same-file references for non-.dtsi
> files, so this is a known false positive of the per-file checker
> given this board family's #include-based override architecture,
> and is not fixed here to avoid breaking the regulator reference.
> 
> All four files pass "dt-check-style --mode strict" except for that
> documented false positive.
> 
> Signed-off-by: Colin Huang <[email protected]>

Hi Colin,

I might be wrong here, but the commit message feels written by an LLM.

If you have used AI assistance for your series (or only for this patch) 
then please note that, even if you have only used it for the commit 
message, you must declare it via the "Assisted-by" trailer [0][1].

Tan

[0] 
https://docs.kernel.org/process/submitting-patches.html#using-assisted-by
[1] https://docs.kernel.org/process/coding-assistants.html