Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.ozlabs.lists.openbmc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mmc,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <20260318-abiding-sloppy-poodle-efd3e5@quoll> |
On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote: > Describe AST2700 as compatible with the existing AST2600 SD controller > and SDHCI bindings by requiring fallback compatibles in the device tree. > > Also require `resets` on the AST2700 SD controller node. > > Signed-off-by: Ryan Chen <[email protected]> > --- > Changes in v2: > - add missing blank line > - modify ast2700 compatible items const Why? > --- > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 39 +++++++++++++++++----- > 1 file changed, 31 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > index d24950ccea95..9c8e068964a1 100644 > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > @@ -22,10 +22,14 @@ description: |+ > > properties: > compatible: > - enum: > - - aspeed,ast2400-sd-controller > - - aspeed,ast2500-sd-controller > - - aspeed,ast2600-sd-controller > + oneOf: > + - const: aspeed,ast2400-sd-controller > + - const: aspeed,ast2500-sd-controller > + - const: aspeed,ast2600-sd-controller No, previous code was correct. Is this some microslop LLM product? I questioned style last time and now we got random changes without explanation. Please confirm - did you use any LLM microslop tools to create this patch? Please also confirm - who internally reviewed this patch before posting? Best regards, Krzysztof