RE: [PATCH 2/7] soc: aspeed: Introduce core eSPI controller support

Hi Oleksandr,

> > +     if (espi->ops->espi_pre_init)
> > +             espi->ops->espi_pre_init(espi);
> is there a chance ops are unitialized? In any place you do this check

It should be properly initialized when adding support for a new SoC. We will remove this check in the next revision.

> > +     if (!espi)
> > +             return;
> espi pointer is unlikely to be null here, I suggest removing the NULL check

Got it. We will also address this in the next revision.

Thanks for your review and comments.