Re: [PATCH u-boot v2] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
Ender Hsieh <[email protected]>
| Newsgroups | org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <[email protected]> |
> I think that the u-boot implementation [1] uses a default value for > the clk delay if it doesn't find a clk-delay node in the DT. You're correct — I verified this earlier in QEMU testing: when I dropped the &scu mac0-clk-delay block in my MSX4 patch, U-Boot still writes hardcoded defaults to the SCU register. > I looked through Ender's efforts and it seems surprising that it > works for their board. Maybe the board design is different in some > manner there? Yes — likely a PCB layout / PHY tolerance coincidence rather than by design. The hardcoded defaults combined with PHY internal delay happen to land within 1Gbps tolerance on the MSX4 board. Happy to test your v3 on alon8, to verify the explicit defaults restore the same behaviour. Thanks, Ender