Re: [PATCH v2 0/2] Add crosvm recipe to meta-virtualization
Bruce Ashfield <[email protected]> Fri, 19 Jun 2026 20:42:33 -0700 (PDT)
| Newsgroups | org.yoctoproject.lists.meta-virtualization |
|---|---|
| Message-ID | <[email protected]> |
Thanks for the v2! Most of my v4 feedback is addressed — gitsm dropped in favour of explicit clones, PV/PKGV cleaned up, SUMMARY expanded, README + test instructions added, and the qemux86-64 nested-KVM path gives me something I can actually reproduce here. Appreciated. But for a v3, make sure to summarize the changes from the previous version. I had to look up the old comments and that gets a bit tedious when doing a lot of reviews. Per-patch comments are on the individual messages. The main one is on 1/2 — a one-character SRC_URI change that lets the whole do_filter_minijail_cargo_config task go away. 2/2 just has a typo and a small nit. With those addressed, and a reply on the three v4 items I still don't see resolved (BBCLASSEXTEND, wayland, crate-licence variation — replies on-list are fine for the latter two, no need to be code changes), I think we're close to a mergeable v3. Bruce