Re: [PATCH v2 2/2] crosvm-image-minimal: add a reference image for crosvm demo
Bruce Ashfield <[email protected]> Fri, 19 Jun 2026 20:42:37 -0700 (PDT)
| Newsgroups | org.yoctoproject.lists.meta-virtualization |
|---|---|
| Message-ID | <[email protected]> |
Mostly looks good. The "host kernel is the guest kernel" pattern is
honest for a demo, the dependency wiring (do_rootfs[depends] on guest
image + kernel deploy) is correct, and bundle_crosvm_guest is
defensive (readlink -f, install -m 0644, bbfatal on missing inputs).
README is concrete and reproducible.
Two minor things:
- SUMMARY typo: "demo its uage." → "demo its usage."
- KVM_MODULES:aarch64 = "" is identical to the unconditional
KVM_MODULES = "" default. Either drop the override, or keep it
only if you want the explicit per-arch line as documentation
of the "kvm is built-in on arm64" fact.
Bruce