Re: [AUH][PATCH v3 4/4] upgrade-helper.py: Add resume option to skip already attempted recipes

On Mon, 4 May 2026 at 08:36, <[email protected]> wrote:
> +            prev_runs = sorted(glob.glob(os.path.join(self.uh_dir, "20*")))
> +            prev_runs = [r for r in prev_runs if r != self.uh_work_dir]
> +            if prev_runs:
> +                prev_dir = prev_runs[-1]

This makes me wonder, if AUH was interrupted in its second run, and we
need to resume for the second time, then AUH should combine everything
from all previous runs into the skip set, not just recipes from the
latest one, right?

> +            if 'workdir' in g:
> +                if any(g['name'] == s['name'] for s in succeeded_pkggroups_ctx):

This is more complex than the condition in the removed block below,
why not use that:
           if g in succeeded_pkggroups_ctx:

> +                if not os.path.exists(link):
> +                    os.symlink(g['workdir'], link)

Why is the existence guard needed? The removed code block doesn't have it.

Alex