Re: patch

On Thu, Aug 23, 2001 at 05:10:22PM +0200, H . Merijn Brand wrote:
> 	1. mkovz.pl accepts smoke folder as second argument, making only
> 	   smoke.sh candidate for editing
> 	2. Michael's changes from Aug 22
> 	3. smoke.sh expands PATH with starting location of smoke.sh
> 	4. added README (just for starters)
> 	5. added Makefile.PL (not ready for use (yet))

Why does this require 5.6?

> 	6. smoke.sh accepts source dir as argument
> 	7. added ChangeLog
> 	8. added MANIFEST

Attached should be the complete diffs I'm running with. I'm not suggesting
that all the bits of the patches should go in, but I did find

(mktest.pl 2>&1) >mktest.log || echo mktest.pl exited with exit code $?
mkovz.pl [email protected] $PC || echo mkovz.pl exited with exit code $?

in smoke.sh useful for debugging when things went wrong

The only change to mkovz.pl is to use "mail" rather than "mailx" on FreeBSD.

In mktest.pl

This seems to fix a bug:

 if (-s "perl.nok.$$") {
     print TTY "\nNot OK file ...";
-    open NOK, "< perl.nok";
+    open NOK, "< perl.nok.$$";
     my @nok = <NOK>;


There's a ./Configure rather than ./Configuration :-) and I've taught it that
FreeBSD can't do long doubles, so no need to build duplicate tests.

It would be nice if the 5.005_03 incompatible "open my $pol" were not used,
as it means mktest.pl needs editing if it is to be run on a machine without
5.6 or later installed.

Nicholas Clark