Re: patch

Check my new sig!

On Fri 24 Aug 2001 14:56, Nicholas Clark <[email protected]> wrote:
> On Thu, Aug 23, 2001 at 05:10:22PM +0200, H . Merijn Brand wrote:
> > 	1. mkovz.pl accepts smoke folder as second argument, making only
> > 	   smoke.sh candidate for editing
> > 	2. Michael's changes from Aug 22
> > 	3. smoke.sh expands PATH with starting location of smoke.sh
> > 	4. added README (just for starters)
> > 	5. added Makefile.PL (not ready for use (yet))
> 
> Why does this require 5.6?

open my $fh, "< blah" or die "foo: $!";

> > 	6. smoke.sh accepts source dir as argument
> > 	7. added ChangeLog
> > 	8. added MANIFEST
> 
> Attached should be the complete diffs I'm running with. I'm not suggesting
           ^^^^^^^^^ ?
> that all the bits of the patches should go in, but I did find
> 
> (mktest.pl 2>&1) >mktest.log || echo mktest.pl exited with exit code $?
> mkovz.pl [email protected] $PC || echo mkovz.pl exited with exit code $?

Added in 1.03

> in smoke.sh useful for debugging when things went wrong
> 
> The only change to mkovz.pl is to use "mail" rather than "mailx" on FreeBSD.

Enlighten me, FreeBSD does *not* support mailx?
IIRC, earlier versions of mail (maby very old, did not support the -s option
to pass the subject, that's why I chose mailx)

> In mktest.pl
> 
> This seems to fix a bug:
> 
>  if (-s "perl.nok.$$") {
>      print TTY "\nNot OK file ...";
> -    open NOK, "< perl.nok";
> +    open NOK, "< perl.nok.$$";

Seems OK to me now. But since mkovz.pl has entered the arena, I surely hope
nobody is actualy sending the .ok and .nok message to perlbug.

>      my @nok = <NOK>;
> 
> 
> There's a ./Configure rather than ./Configuration :-) and I've taught it that

D'uh! I prefixed the wrong line with "./"
Fixed in 1.03

> FreeBSD can't do long doubles, so no need to build duplicate tests.

If $^O for FreeBSD is "FreeBSD", would the following change do?

if ($^O =~ m/^(?: hpux | FreeBSD )$/x && $conf =~ m/longdouble|morebits/) {

> It would be nice if the 5.005_03 incompatible "open my $pol" were not used,
> as it means mktest.pl needs editing if it is to be run on a machine without
> 5.6 or later installed.

Did you detect any other deps, I've gotten so used to it now that I tend to
forget what is new in 5.6 :)

Changed.

I've dropped the requirement. Hope there are no other backward
incompatibilities.

Now I should start to *use* this stripped version myself in order to submit
tested software :-P

-- 
H.Merijn Brand    Amsterdam Perl Mongers (http://www.amsterdam.pm.org/)
using perl-5.6.1, 5.7.1 & 628 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: [email protected]
http://archives.develooper.com/[email protected]/   [email protected]
send smoke reports to: [email protected], QA: http://qa.perl.org