Re: patch

On Fri, Aug 24, 2001 at 03:18:47PM +0200, H . Merijn Brand wrote:
> Check my new sig!
> 
> On Fri 24 Aug 2001 14:56, Nicholas Clark <[email protected]> wrote:
> > On Thu, Aug 23, 2001 at 05:10:22PM +0200, H . Merijn Brand wrote:

> > > 	5. added Makefile.PL (not ready for use (yet))
> > 
> > Why does this require 5.6?
> 
> open my $fh, "< blah" or die "foo: $!";

Ah

> > Attached should be the complete diffs I'm running with. I'm not suggesting
>            ^^^^^^^^^ ?
> > that all the bits of the patches should go in, but I did find

It's defensive typing. I'm in xemacs editing a message. When I go back to
mutt I have to remember to attach the files. Sometimes I forget (As I appear
to have done with that message) so I feel more honest in saying that I mean
to attach them, not that they "are" attached. It's probably silly, and
confusing.

> Enlighten me, FreeBSD does *not* support mailx?
> IIRC, earlier versions of mail (maby very old, did not support the -s option
> to pass the subject, that's why I chose mailx)

It would appear that mailx is in the ports collection, and not built by
default. A straw pole of the 3 BSD machines I have access to:

nick@plum [nick]$ whereis mailx
mailx: /usr/ports/mail/mailx
nick@plum [nick]$ mailx
bash: mailx: command not found

nick@roast [nick]$ whereis mailx
mailx: /usr/ports/mail/mailx
nick@roast [nick]$ mailx
bash: mailx: command not found

nwc10@colon nwc10$ whereis mailx
mailx: /usr/ports/mail/mailx
nwc10@colon nwc10$ mailx
bash: mailx: command not found


> > FreeBSD can't do long doubles, so no need to build duplicate tests.
> 
> If $^O for FreeBSD is "FreeBSD", would the following change do?
> 
> if ($^O =~ m/^(?: hpux | FreeBSD )$/x && $conf =~ m/longdouble|morebits/) {

It's freebsd, so ~ m/^(?: hpux | freebsd )$/x will match.

> > It would be nice if the 5.005_03 incompatible "open my $pol" were not used,
> > as it means mktest.pl needs editing if it is to be run on a machine without
> > 5.6 or later installed.
> 
> Did you detect any other deps, I've gotten so used to it now that I tend to
> forget what is new in 5.6 :)

I think that that was it for 5.6isms.

Ooh. New instructions in sig:

> send smoke reports to: [email protected], QA: http://qa.perl.org

Nicholas Clark