Re: Smoke [5.8.1] 21308 PASS-so-far freebsd 4.8-rc (i386/1 cpu)

Op een zonnige herfstdag (Monday 22 September 2003 13:05), schreef Nicholas 
Clark:

> I don't understand why so few combinations are being run:

Well, partly because you found bug in Test::Smoke::BuildCFG - where the last 
blank line in a section was ignored - and partly because your cfg is not 
quite up to the recent implementation of the configuration file.

I have fixed the bug in Test::Smoke::BuildCFG and pending your answer for the 
smokeconfig.pl issue, the fix will be in 1.18.06 MAINT which I want to get to 
CPAN asap.

> I'm confused

Join the club ;-)

I think I need to clarify how I implemented the substitution sections in the 
cfg (after consulting with Merijn)

1) Substitution will *only* take place for the 'ccflags' variable in 
F<Policy.sh> which needs to be present as <builddir>/../Policy.sh

2) In fact a substitution rule can only *remove* options from that variable 
(in the case of a blank line in the substitution section of the cfg) and will 
not add them.

In short, to do the -DPERL_COPY_ON_WRITE thing you have 2 options:

1) Use the documented: C<-Accflags='-DPERL_COPY_ON_WRITE'> in a section of the 
cfg

2) Edit your F<< <builddir>/../Policy.sh >> and add the -DPERL_COPY_ON_WRITE 
option to the C<ccflags> variable and create a section like the -DDEBUGGING 
one:

	=
	/-DPERL_COPY_ON_WRITE/

	-DPERL_COPY_ON_WRITE
	=

Take your pick...
IMO: 1) is easier and quicker, and 2) looks nicer in the reports


Good luck,

Abe
-- 
Schwern> Anything else you'd like?  Side order of fries?  Clean your stables?
Schwern> Get you an apple?  Part the Red Sea?

I guess I otherwise would sense some sarcasm in your voice but
unfortunately my sarcasm-o-meter burned out years ago from prolonged
exposure to myself.
                                   -- Jarkko Hietaniemi on p5p @ 2002-02-03