[PATCH] was Re: ahoy! gold gold gold gold alpha and a bottle o rum
[email protected] (John Peacock)
| Newsgroups | perl.module.build |
|---|---|
| Message-ID | <[email protected]> |
Eric Wilhelm wrote: > We'll give her a right three days or four nights to bob in the harbor > afore we run the jolly 0.3 up the mainstaff and weigh anchor for the > high seaPANs. Since you're still smoking CPAN, this may not be too late. I just realized that I never sent you the version-0.76 patch for inclusion in Module::Build::Version. It's actually kind of important, since certain older distros could have a META.YML that causes version.pm to core (the XS version anyways). There's also a tiny little POD included that I had suggested... John
version-0.76.patch
(text/x-patch, 1.4 KB)
=== lib/Module/Build/API.pod
==================================================================
--- lib/Module/Build/API.pod (revision 2248)
+++ lib/Module/Build/API.pod (local)
@@ -268,6 +268,10 @@
this process, so there's no real opportunity to change to something
better.
+If the target file of L</dist_version_from> contains more than one package
+declaration, the version returned will be the one matching the configured
+L</module_name>.
+
=item dynamic_config
[version 0.07]
=== lib/Module/Build/Version.pm
==================================================================
--- lib/Module/Build/Version.pm (revision 2248)
+++ lib/Module/Build/Version.pm (local)
@@ -74,7 +74,7 @@
use locale;
use vars qw ($VERSION @ISA @REGEXS);
-$VERSION = 0.74;
+$VERSION = 0.76;
push @REGEXS, qr/
^v? # optional leading 'v'
@@ -426,7 +426,11 @@
require Carp;
Carp::croak("Invalid version object");
}
- return $self->{original};
+ return exists $self->{original}
+ ? $self->{original}
+ : exists $self->{qv}
+ ? $self->normal
+ : $self->numify;
}
sub vcmp
@@ -557,7 +561,8 @@
# Thanks to Yitzchak Scott-Thoennes for this mode of operation
{
local $^W;
- *UNIVERSAL::VERSION = sub {
+ *UNIVERSAL::VERSION # Module::Build::ModuleInfo doesn't see this now
+ = sub {
my ($obj, $req) = @_;
my $class = ref($obj) || $obj;