Re: [Tiki-devel] On subscribeNewsletter.tpl replacing the label for an Email icon as placeholder.
Bsfez Tiki via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
+1 I was affraid I added too much changes already. ;-) Will create a merge request later today. B > On 26 Jan 2021, at 12:14 , Jonny Bradley via TikiWiki-devel <[email protected]> wrote: > > Looks good to me, but while you're at it, why not make the button stick on the end of the text input using an input group? > > https://getbootstrap.com/docs/4.6/components/input-group/#button-addons > > jb > > > > >> On 26 Jan 2021, at 08:57, Bsfez Tiki via TikiWiki-devel <[email protected]> wrote: >> >> Hello, >> >> This several Tikis (21 and 22) that I use the Subscribe to newsletter wiki-plugin to collect mail address. >> However I really don’t like the way we display label and mandatory asterisk. (look oldish to me and the only field is the email so it is obviously mandatory 😃) >> >> I replaced this with an envelope icon displayed as a placeholder (inside the field). >> >> Something to commit or to keep to myself ? >> >> At themes/templates/wiki-plugins/wikiplugin_subscribenewsletter.tpl >> <div class="form-group row"> >> <label class="{if $inmodule}col-md-12{else}col-md-3{/if} col-form-label" for="wpEmail">{tr}Email{/tr} <strong class='mandatory_star text-danger tips' title=":{tr}This field is mandatory{/tr}">*</strong></label> >> <div class="{if $inmodule}col-md-12{else}col-md-9{/if}"> >> <input type="email" class="form-control" id="wpEmail" name="wpEmail" value="{$subscribeEmail|escape}"> >> </div> >> </div> >> >> >> Changed to this: >> >> <div class="form-group row justify-content-center"> >> <div class="{if $inmodule}col-md-12{else}col-md-9{/if}"> >> <input type="email" class="form-control fa" id="wpEmail" name="wpEmail" value="{$subscribeEmail|escape}" placeholder=""> >> </div> >> </div> >> >> Bernard >> >> --- >> >> PS: The field is pretty wide so I reduced the width and moved the button to the end of it, but look to me a personal custom. >> >> <div class="form-inline row justify-content-center"> >> <div class="{if $inmodule}col-md-12{else}col-md-9{/if}"> >> <input type="email" class="form-control fa" id="wpEmail" name="wpEmail" size="50" value="{$subscribeEmail|escape}" placeholder=""> >> {if empty($subcribeMessage)} >> <input type="submit" class="btn btn-primary" name="wpSubscribe" value="{tr}Subscribe to the newsletter:{/tr} {$subscribeInfo.name}"> >> {else} >> <input type="submit" class="btn btn-primary" name="wpSubscribe" value="{$subcribeMessage|escape}"> >> {/if} >> </div> >> </div> >> >> <Screen Shot 2021-01-26 at 10.56.40 .png> >> >> _______________________________________________ >> TikiWiki-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > > _______________________________________________ > TikiWiki-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel _______________________________________________ TikiWiki-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel