Re: Proper Copyright Year in PHP files now an automated QA tasks
jojodee <jojodee-8nna1qhvBBM9QQeoy3GH/[email protected]> Sat, 21 Feb 2009 13:54:22 +1030
| Newsgroups | gmane.comp.cms.xaraya.devel |
|---|---|
| Organization | Xaraya |
| Message-ID | <[email protected]> |
Hb wrote: > Marcel van der Boom schrieb: >>> The RFC was updated accordingly from the existing >>> single year, to display a year range in the RFC at that time: >>> Revision cc044b0d0edd0a5439b2f3f3d2e338adf3888525 > As already posted in this thread elsewhere, that was indeed the revision i changed the example to that agreed upon after discussion with Marcel/PMC (who were all doing this work during 2004). Marcel is correct that in the original proposal, and in the snippet he posted about the copyright syntax it listed a number of options and the range was not one. (for anyone's interest, all these decisions and discussions and so on were very well documented in the main and can be found with all the work done by Marc too, and the checking that was done in the code, in the logs of meetings all through 2004 mainly and in 2005 (we used to have regular meetings). Some however is documented in the PMC logs and some in PMC discussion/meeting logs. Just in case it was missed in this thread (like the revision i posed), before the copyright headers were changed in the code, for practical reasons the range was chosen over listing year numbers separately, after the ad nauseum discussion on it. Certainly, given there was so many files to change we wanted to get it right before we changed anything so thus the long discussion. I was asked to update RFC 44 with the example to be used for the headers, to document the that decision which i did in that commit. I might add - the changes to the headers didn't take minutes, they took days and it went on over months .. and then was redone after the merge of anacreon in 1.1, and others helped or corrected them where there were typos etc. So ... not much else i can say if people are saying it should be different now .. 2004-2009 is a long time to be looking at those headers :) >> <t><spanx>Indenting</spanx> >> <t> >> - Use an indent of 4 spaces. Do not use the tab character for >> - indentation. Most editors will have a configuration option for this >> . >> + Use indents of 4 spaces in code and of 2 spaces in template files. >> + Do not use the tab character. Most editors will have a configuration >> + option for this. >> </t> >> Why are we changing to 2 spaces in templates? was there some decision somewhere? Personally i find 2 spaces too small to clearly show tree/hierarchy in the files. I understand why 4 spaces can push the code out over 80 chars etc, but the same argument stands for the php files. Jo