Re: Lightproof extension integration broken

 Hello!

On 2010-07-27 15:58, Petr Mladek wrote:
> Pavel Lastovicka píše v Čt 22. 07. 2010 v 16:25 +0200:
>> Hello,
>>
>> I have noticed in the Windows OO.o installation program that there is empty item for 
>> the Lightproof extension under the Extensions feature.
>>
>> In scp2/source/extensions/module_extensions.scp there is:
>>
>> #ifndef WITHOUT_EXTENSION_LIGHTPROOF
>> #ifdef WITH_EXTENSION_INTEGRATION
>> Module gid_Module_Optional_Extensions_LightProof
>>      MOD_NAME_DESC(MODULE_OPTIONAL_EXTENSIONS_LIGHTPROOF);
>>      ParentID = gid_Module_Optional_Extensions;
>>      Minimal = NO;
>>      Default = YES;
>>      Styles = ( );
>> End
>> #endif
>> #endif
>>
>> The first line should be #ifdef WITH_EXTENSION_LIGHTPROOF. Also the "Files" 
>> statement is missing in module definition.
> KAMI, could you please look at it?
>
> I do not pack this extensions and am not sure how it is supposed to
> work. I guess that we need to pack more files: the main lightproof
> extension and lang packs.
Maybe #ifdef WITH_EXTENSION_LIGHTPROOF is okay. It seems configure
contains +    SCPDEFS="$SCPDEFS -DWITH_EXTENSION_LIGHTPROOF" so we
should go there.
> I see only one file entry in scp2/source/extensions/file_extensions.scp.
> It is used in the module definition in
> scp2/source/extensions/module_extensions_lightproof.scp.
>
Lightproof is a special case of scp usage, because it uses language
templates (scp2_extensions_templates.diff) and modules.

The desired behavior is something like:
[-] Extension
     [-] Lighproof
          English
          Hungarian
You can install only for (UI)  matching languages so this time English
ang Hungarian only.
> The module definition in scp2/source/extensions/module_extensions.scp
> seems to be broken and probably obsoleted.
>
KAMI
-- 

Best regards,

Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com


My favorite projects:

OxygenOffice Professional <http://ooop.sf.net/> - office suite - for everybody | Magyarul <http://hun.sf.net/> - In Hungarian

Blog <http://bit.ly/10ucTR> | Support <http://bit.ly/eYZO6> 

Follow me <http://bit.ly/gJuJZ>, if you can <http://bit.ly/kDocB>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMTu4zAAoJECCg8GbdPF49/EgP/jYawAP7HcfGXnNsj2tlCePB
bFyPgx81f02vFdSXOktxzaJNJYHzUZJJp4UGTotShTphk318SA/e8gGX6wO6BPw3
laLLJPmwQ7UUAGhcPnvxaxEvcdrIGYFxqNfIXoGfdrXD3EFsj0X5Nrcd+rI4u4/M
Q2Z6RX05ul54Sh1jA9hviPFEEXPPcIKRkR3nG81W+rPmY61sAyDZ8RypCmWszYWt
9iuHho9sHUsDM7MPFl25c9chMbQvoTmZHwbzqUnVY4LmuJA1GcfBIUvlBPSQvihS
Moa03ksKoivY0cM7WMh5qOSsPLF/CtNZPhwdsJSk98rc+3vvMDHurAA+Fst12osz
fWozg2hD9caxZ+L4cAD8Jes2CG37X4YgGL0oH3FcD8tI/NHN5hCsOREp8+XggXYZ
iVrl7DVeV+THXs/JqAjo89u2xzdwV5Ttg2lopkS5WJIZgaJtdGyyenCZySJUds5p
pCsXyk8d5CMkG53mMvuZIF4ok4qspD4uvvV8XpVbWnNvDhhUFo5HPC68WwcENZ1a
yf1BHbdqScEk//xeDvtOiT323a1IJQudGUMAxpXYoG/xGMOZIORGQZNB3Jn6+5Cg
41+8F4VVY+oZ6nG6azpWNqTh2C0FV5ppbeLOcnlNApPaczUtFzzyWlipWcc1xNBN
EAQQOyrX8PKwS1WR22Ey
=8skQ
-----END PGP SIGNATURE-----