Re: [Crystal-cvs] SF.net SVN: crystal:[38539] CS/trunk/libs/csutil/csstring.cpp

This change looks suspect. csStrCaseCmp() does a full string comparison, so
it is not a replacement for a strstr()-style search.

-- ES

On Tuesday, July 24, 2012, wrote:

> Revision: 38539
>           http://crystal.svn.sourceforge.net/crystal/?rev=38539&view=rev
> Author:   weltall2
> Date:     2012-07-24 06:51:47 +0000 (Tue, 24 Jul 2012)
> Log Message:
> -----------
> changed the used function to the internal one
>
> Modified Paths:
> --------------
>     CS/trunk/libs/csutil/csstring.cpp
>
> Modified: CS/trunk/libs/csutil/csstring.cpp
> ===================================================================
> --- CS/trunk/libs/csutil/csstring.cpp   2012-07-23 20:16:48 UTC (rev 38538)
> +++ CS/trunk/libs/csutil/csstring.cpp   2012-07-24 06:51:47 UTC (rev 38539)
> @@ -433,7 +433,7 @@
>    char const* tmp;
>
>    if (ignore_case)
> -    tmp = strcasestr(p + pos, str);
> +    tmp = csStrCaseCmp(p + pos, str);
>    else
>      tmp = strstr (p + pos, str);
>
>
> This was sent by the SourceForge.net collaborative development platform,
> the world's largest Open Source development site.
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Crystal-cvs mailing list
> [email protected] <javascript:;>
> https://lists.sourceforge.net/lists/listinfo/crystal-cvs
>

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop