Re: K3b 1.0.1 eject problem
Sebastian Trüg <[email protected]>
| Newsgroups | gmane.comp.kde.k3b |
|---|---|
| Message-ID | <[email protected]> |
On Wednesday 20 June 2007 14:36:27 [email protected] wrote: > I found out that with the patch > > (k3bdevice.diff, > which I sent in earlier mail, but without changes in: > "int K3bDevice::openDevice( const char* name, bool write )" > and "bool K3bDevice::Device::isOpen() const"; > the changes should be only in: > "bool K3bDevice::Device::open( bool write ) const") > > I can also eject and quit K3b > properly (with DVD+R VIDEO). > > Perhaps this is the best solution?! Not really because it does not fix the bug but simply works around it, thus undermining the whole point of the mutex. The mutex is used to block the device k3b-wide to ensure that no two threads (or even processes in the case of growisofs or cdrecord) access the device at the same time. Your patch uses a different mutex for open() which means that k3b can still open the device although it should be blocked during growisofs' operation. cheers, Sebastian ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/