Am Freitag, 6. Juli 2018 10:51:28 UTC+2 schrieb Francesco Lodolo [:flod]:
> Il 06/07/18 10:42, Jorg Knobloch ha scritto:
> > Hi all,
> >
> > it has come to my attention that the access keys for the new attachment pane functionality have been incorrectly translated in some/most locales.
> >
> > There are three access keys that should all be the same:
> >
> > attachments.accesskey
> > toggleAttachmentPaneCmd.accesskey
> > toggleAttachmentPaneCmd.key
> >
> > attachments.accesskey is the access key on the attachment pane header.
> >
> > toggleAttachmentPaneCmd.accesskey is the access key on the View menu of a Compose/Write window.
> >
> > toggleAttachmentPaneCmd.key is a keyboard shortcut, not an access key, which will show or hide the attachment pane.
> >
> > Picture here:
> > http://www.jorgk.com/misc/attachments.png
> I'm not surprised most locales got it wrong (I would have too…). It
> looks like this UI is mixing up access keys and shortcuts? Is that
> really the case?
There's no mixup. They are defined independently, they work independently, and they are advertised independently.
We have just extended the access key functionality to /also/ act as a shortcut for toggling the attachment pane (hide when it has focus, or show). Extended access key functionality has been coded to work automatically, regardless of the shortcut key. But we are recommending to make access key and shortcut key the same, which has several advantages:
- convenient and efficient
- improved mnemonics: just one key combo to remember for getting in or out of attachment pane
- better ux-discovery of the extended access key, because the shortcut key (== access key for conforming locales) will be advertised on the View > Attachment Pane menuitem.
- avoiding separate shortcut key for toggling, as shortcut keys are in short supply
To simplify things for localizers, we could create the keytext in code so that we eliminate the <key> altogother, as I explained above.
> Why should accesskey and shortcut use the same letter? There's no
> guarantee that all languages will have a M in the label.
No, there's a misunderstanding here.
Every locale already has their localized attachments.accesskey as an existing, unique access key for the "N attachment(s)" label (if it's not unique, it's broken, i.e. someone got it wrong). Then you just assign the same key (e.g. "M" for English, or "N" for German) for toggleAttachmentPaneCmd.key. Iow, you make the shortcut key the same as the localized access key. So that definitely works regardless of your language. Guaranteed.
Then ideally, you also make toggleAttachmentPaneCmd.accesskey the same key again for the menu access key (but no problem if you don't).
_______________________________________________
dev-l10n mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-l10n
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.