Re: RFE #833097
"Hiroaki Itoh" <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <[email protected]> |
Jerzy,
> It may be good idea to slow down the refresh rate rather than
stopping it
> completely. We have the flag to indicate that we are "in the
background" and
> it should be enought to set it appropriate. I am not sure about the
modal
> dialog detection code - I will have to make some testing first. I
don't feel
> comfortable using timer for that, perhaps WM_ACTIVATE message
handler or
> similiar will be better.
You mean, like this?
=============================================
void CMainFrame::OnActivate(UINT nState, CWnd* pWndOther, BOOL
bMinimized)
{
/*__*/CCJMDIFrameWnd::OnActivate(nState, pWndOther, bMinimized);
/*__*/
/*__*/CWincvsApp* pApp = (CWincvsApp*)AfxGetApp();
/*__*/ASSERT(pApp);
/*__*/CWnd* pActive = GetActiveWindow();
/*__*/LONG style = ::GetWindowLong(pActive->GetSafeHwnd(), GWL_STYLE);
/*__*/CMDIChildWnd* pMaybeFView = MDIGetActive();
/*__*/if( ( (style & DS_MODALFRAME) || pMaybeFView->GetSafeHwnd() ==
pApp->GetFileView()->GetSafeHwnd() ||
/*______*/... // pApp->SetBackgroundProcess(true or false);
=============================================
Using WM_ACTIVATE handler is good for me, too, and also
WM_TIMER is uncomfortable for me. But individually,
I prefer ignoring completely...because modal is modal.
Assuming people who are just writting commit logs,
are they interest in file changes?
> On more option would be to try using NT-specific API
ReadDirectoryChangesW
> ...
> methods and detect the system we are running on and select as
appropriate.
Though I have no experience using ReadDirectoryChangesW,
if we can detect more details of changes when using it,
it sounds ideal.
> Most of the time you can post in both places - we will discuss it
here but
> it's good to have the code together with bug or features request so
it will
> not get lost or forgotted. If the code is big it's better to make a
zip file
> and post it to the files area of cvsgui-dev list or attach to the
bug at SF.
I see. It is important to make it not buried.
Yahoo! Groups Links
To visit your group on the web, go to:
http://groups.yahoo.com/group/cvsgui-dev/
To unsubscribe from this group, send an email to:
[email protected]
Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/