[manet] Mahesh Jethanandani's Discuss on draft-ietf-manet-dl ep-da-credit-extension-20: (with DISCUSS and COMMENT)
Mahesh Jethanandani via Datatracker <[email protected]>
| Newsgroups | gmane.ietf.manet |
|---|---|
| Message-ID | <173845739413.155519.12276369567749817459@dt-datatracker-6f7f8bdd64-4ngzm> |
Mahesh Jethanandani has entered the following ballot position for draft-ietf-manet-dlep-da-credit-extension-20: Discuss When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-manet-dlep-da-credit-extension/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- Here, here! This DISCUSS is just that. A DISCUSSion around how something could be clarified better. I expect it should be fairly easy to address it. Section 3, paragraph 2 > If this extension is supported, that support MUST be declare using > the Extensions Supported Data Item (see Section 13.6 of [RFC8175]). > DiffServ Aware Credit Window Extension Data Items MUST NOT be emitted > by a DLEP participant unless such support was specified in the > initialization message received from its peer. The use of the > extension defined in this document SHOULD be configurable on both > modems and routers. The document clearly states that the extension needs to be configured on both modems and routers. Further down there are references to "network management mechanisms", which could imply NETCONF/RESTCONF, or they could also imply Syslog but that is not entirely clear reading the document. How exactly is this feature going to be configured if there is no YANG module defined or planned? Can it be explained better? ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- All comments below are about very minor potential issues that you may choose to address in some way - or ignore - as you see fit. Some were flagged by automated tools (via https://github.com/larseggert/ietf-reviewtool), so there will likely be some false positives. There is no need to let me know what you did with these suggestions. Section 1, paragraph 1 > The Dynamic Link Exchange Protocol (DLEP) is defined in [RFC8175]. > This protocol provides the exchange of link related control > information between DLEP peers. DLEP peers consist of a modem and a > router. DLEP defines a base set of mechanisms as well as support for > possible extensions. This document defines one such extension. s/This protocol/The protocol/ Document references draft-ietf-manet-dlep-credit-flow-control-16, but -17 is the latest available revision. Document references draft-ietf-manet-dlep-ether-credit-extension-07, but -08 is the latest available revision. Section 1, paragraph 2 > ws may be shared or dedicated on a per flow basis. See [I-D.ietf-manet-dlep-e > ^^^^^^^^ In this context, "per-flow" forms an adjective and is spelled with a hyphen. Section 2, paragraph 1 > is supported, that support MUST be declare using the Extensions Supported D > ^^^^^^^^^^ There may an error in the verb form "be declare". _______________________________________________ manet mailing list -- [email protected] To unsubscribe send an email to [email protected]