RE: Comments of Antti Tuominen on CTP draft

[email protected] Fri, 24 Oct 2003 18:05:34 +0300
Newsgroups gmane.ietf.seamoby
Message-ID <[email protected]>
Hi,

> Review comments
> ---------------
> 
> 1. In 2.3 it is specified that length is in 8 octet units.  However,
>    if presence vector and data are not present we have 4 octet
>    message.  Also context data may not 64bit align (especially when a
>    presence vector is used).  So it seems to me that you either have
>    to have 1 octet as the unit (which of course limits length to 255
>    bytes) or do padding.

good point. I've fixed this.

> 2. Also in 2.3 you use presence vector and presentation vector, so I
>    guess s/Presentation Vector/presence vector/.

Got it, thanks.

> 3. In 2.4.1, what are Type=Auth-Token and Type Len?  No description,
>    seem redundant.  Same thing in 2.4.3 (also Algorithm) and 2.4.6.
>    Old remnants?

Yes, deleted tye type=x part, and made the reply field a full 64 bits.

> 4. Example in Appendix C is wrong.  First, you do not "subscribe" to
>    all-nodes.  Node never sends MLD Report or Done for all-nodes.
>    Second, you don't put Routing Header in MLD messages, but Router
>    Alert Hop-by-hop option which is just 6 bytes (or 8 padded).  In
>    consequence, all time and space overhead calculations are
>    incorrect.

got it.

thanks,
John