Re: reform-tools_1.82-2~bpo13+1_both.changes REJECTED

Johannes Schauer Marin Rodrigues <[email protected]> Sat, 06 Dec 2025 22:30:30 +0100
Newsgroups	gmane.linux.debian.backports.general
Message-ID	<176505663075.713870.2940644555839578895@localhost>
Hi Nicholas,

thank you for your elaborate reply! Unfortunately you seem to have missed my
other mail to this thread. The mystery is solved!

Quoting Nicholas D Steeves (2025-12-06 21:22:07)
> This is an interesting mystery, and no, you're not dumb.  I'm going to
> assume that you're not using a dgit-style "patches-applied" Debian
> packaging branch in the analysis below:

Indeed there are no patches. :)

> Here's what we know:
> 
>   1. A Debian Backports ftpmaster knows about reform-power-daemon.patch.
>   2. That ftpmaster looked at a source package you uploaded.
>   :. Thus this patch was part of your upload.
> 
>   3. That file doesn't exist in any copy of the packaging anymore.
>   4. That file isn't checked into git in any local or remote branch.
>   :. That file was probably never checked into git, or a git reset
>      --hard wiped out.

All correct.

> If you checkout a patch-queue/suite-name branch you might be able to
> find the git commit that was gbp exported to generate
> reform-power-daemon.patch.  I suspect that this was work that didn't
> reach a natural checkpoint or milestone, or else was interrupted before
> it could be checked into git.  If you were working with quilt directly,
> then the evidence of now gone (unless you want to restore from backup).
> 
> Do you still have access to the source package that you uploaded to
> mentors?  Or maybe a copy from a backup?  That would be the fastest way
> to proceed.  Finally, here are the three most likely causes imho:

Adam found the source on coccia in
/srv/ftp-master.debian.org/queue/reject/reform-tools_1.82-2~bpo13+1.debian.tar.xz
and indeed it contained debian/patches/reform-power-daemon.patch

>   reform-power-daemon.patch is work that was destined for 1.82-2, but a
>   `gbp export` didn't occur, or the manually created quilt series wasn't
>   checked-in, so the work was never part of a source package, and was
>   accidentally included in the backport.
> 
> or
> 
>   reform-power-daemon.patch is work that was destined for 1.82-3 and was
>   accidentally included in the backport.
> 
> or
> 
>   reform-power-daemon.patch is specific to the trixie-backport, and
>   1.82-2~bpo won't work properly without it; meanwhile 1.82-2 in sid and
>   testing works fine.

I think what happened was that I had experimented with adding
reform-power-daemon.patch but since I decided against it, I never checked into
git. But I *also* forgot to rm the patch. This means that the file was there
and not tracked by git and when I ran sbuild (which runs dpkg-source -b .) the
file was included in the build because dpkg-source is unaware of which file is
in git or not.

As Martin notes in the other branch of this thread I should move away from
tools which have no knowledge of the packaging git.

Thanks!

cheers, josch
signature.asc (application/pgp-signature, 833 B)