Re: dvd+rw-tools-7.1-consolidated_fixes-1.patch

On 9/25/25 2:56 AM, Xi Ruoyao ([email protected] via blfs-support 
Mailing List) wrote:
> On Wed, 2025-09-24 at 22:36 -0700, Alan Ianson wrote:
>> On Thu, 25 Sep 2025 05:22:56 +0000
>> "\"Ian Macdonald\"" ([email protected] via blfs-support Mailing List)
>> <[email protected]> wrote:
>>
>>> Hi,
>>> Has anybody else had problems with whis patch? For me it fails with
>>> *** malformed patch at line 164:
> I can reproduce it and with a quick glance on the patch I'd say it's
> indeed malformed:
>
> diff -Naurp dvd+rw-tools-7.1.orig/growisofs.1 dvd+rw-tools-7.1/growisofs.1
> --- dvd+rw-tools-7.1.orig/growisofs.1   2008-03-01 04:40:06.000000000 -0600
> +++ dvd+rw-tools-7.1/growisofs.1    2025-08-06 15:24:52.394500633 -0500
> @@ -113,7 +113,7 @@ recordings.
> Actual device names vary from one operating system to another. We use
> \fI/dev/dvd\fP as a collective name or as symbolic link to the actual
> device if you wish. Under Linux it will most likely be an ide\-scsi
> -device  such as "/dev/scd0." Under NetBSD/OpenBSD it has to be a
> +device  such as "/dev/sr0." Under NetBSD/OpenBSD it has to be a
> \fIcharacter\fP SCSI CD\-ROM device such as "/dev/rcd0c." Under Solaris
> it also has to be a \fIcharacter\fP SCSI/ATAPI CD\-ROM device, e.g.
> "/dev/rdsk/c0t1d0s2" or "/vol/dev/aliases/cdrom0." And likewise in
>
> This doesn't seem correct.  In the diff chunks of a patch the unchanged
> lines should start with a whitespace.

I have no idea why this happened. I can reproduce it over here, and on 
my development system (where the patch was created), everything is 
looking good - which explains why I didn't run into the problem during 
tagging.

I've grabbed a copy of the patch currently in the book and diffed it 
against the copy currently on my development system:

renodr [ /tmp ]$ diff -Naurp dvd+rw-tools-7.1-consolidated_fixes-1.patch 
/sources/dvd+rw-tools-7.1-consolidated_fixes-1.patch  | wc -l

457


I looked at the diff again while piping it through 'more', and all 457 
lines are... differences in whitespace.

I have never seen this before. I will get a -2 uploaded right away and 
file an errata.

- Doug

-- 
http://lists.linuxfromscratch.org/sympa/info/blfs-support
Unsubscribe: See the above information page