Re: test failures for 2.2 on Debian buildd's

--=-=-=
Content-Type: text/plain

David Bremner <[email protected]> writes:

> I'm not sure what's going on, but on several architectures, including
> i386 (IA32 for intel employees ;)) the test "Testing auth permanent
> failure with smtp" seems to be hanging.  There isn't any interesting
> output in the logs, just

Eventually I narrowed this down to (what I believe is) a racy test.
test/authtest-smtp.sh removes it's input file, but since it is run by
tcpserver, this happens in a different process than tests/smtp-auth. It
seems that in certain circumstances this can cause a race condition
where the previous test removes the smtp-response file wanted for the
current test. The obvious patch is attached.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-don-t-remove-smtp-response-in-authtest-smtp.sh.patch

From 9db600f58fda5c78969c1852eafba8a33196edd3 Mon Sep 17 00:00:00 2001
From: David Bremner <[email protected]>
Date: Sun, 23 Dec 2018 15:53:21 +0900
Subject: [PATCH] don't remove smtp-response in authtest-smtp.sh

This seems racy as the 'rm' happens in a different process than the
shell running the client side of the test. It also seems unneeded
since each test in tests/smtp-auth overwrites that file
---
 test/authtest-smtp.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/authtest-smtp.sh b/test/authtest-smtp.sh
index 73df37c..fef010a 100644
--- a/test/authtest-smtp.sh
+++ b/test/authtest-smtp.sh
@@ -5,7 +5,7 @@ echo 250-AUTH PLAIN
 echo 250 OK
 read line
 cat $1
-rm -f $1
+# rm -f $1
 read line
 echo 250 OK
 read line
-- 
2.19.2



--=-=-=
Content-Type: text/plain; charset=us-ascii


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--=-=-=--